[Stack Monitoring] add loading state to nodes table#114709
Merged
neptunian merged 2 commits intoelastic:masterfrom Oct 13, 2021
Merged
[Stack Monitoring] add loading state to nodes table#114709neptunian merged 2 commits intoelastic:masterfrom
neptunian merged 2 commits intoelastic:masterfrom
Conversation
neptunian
added
v8.0.0
Team:Infra Monitoring UI - DEPRECATED
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
neptunian
commented
Oct 12, 2021
|
|
||
| async clickNameCol() { | ||
| await find.clickByCssSelector(`[data-test-subj="${SUBJ_TABLE_SORT_NAME_COL}"] > button`); | ||
| await find.byCssSelector('.euiBasicTable-loading'); |
Contributor
Author
There was a problem hiding this comment.
just added this to make sure the indicator exists first
neptunian
commented
Oct 12, 2021
| pagination={pagination} | ||
| onChange={onChange} | ||
| columns={columns} | ||
| loading={props.isLoading || isLoading} |
Contributor
Author
There was a problem hiding this comment.
if props.isLoading (react version) else isLoading (angular). this is because we make the fetch higher up now and need to pass the state down in the react version.
Contributor
Author
|
@elasticmachine merge upstream |
klacabane
approved these changes
Oct 12, 2021
Contributor
Author
|
flaky test runner: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2005/ |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @neptunian |
neptunian
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 13, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a previous PR, I removed the loading state from the angular version and didn't add one to the react version. This causes there to be no loading indicator when fetches are happening in the nodes listing table during table changes, and I believe it also causes the tests to be flakey that are waiting for the loading indicator to not exist. Since it never exists to begin with I think it finishes too early and causes a race condition when clicking a column to sort twice (see error). I think it could be the cause of this test failing sometimes.
Test